DIST-S1 PGE Integration Tests #597
Conversation
| do | ||
| if [[ "$potential_product" == *"$tile_code"* ]]; then | ||
| echo "expected product is $potential_product" | ||
| expected_product=$potential_product |
There was a problem hiding this comment.
I think this should be expected_file not expected_product. It's causing N/A to be propagated to the output HTML report:
There was a problem hiding this comment.
I changed the name to expected_product since we're comparing the whole product directory. The N/A comes from me missing to change a couple references to that, including in the update_html_results_file call. This has been fixed.
There was a problem hiding this comment.
I think the release version for the DIST-S1 Beta delivery is actually 2.1, not 6.0
There was a problem hiding this comment.
All these version numbers...
Maybe we should centralize what is what and what goes where
| [ -z "${PGE_TAG}" ] && PGE_TAG="${USER}-dev" | ||
| [ -z "${INPUT_DATA}" ] && INPUT_DATA="dist_s1_beta_0.0.6_expected_input.zip " | ||
| [ -z "${EXPECTED_DATA}" ] && EXPECTED_DATA="dist_s1_beta_0.0.6_expected_output.zip " | ||
| [ -z "${RUNCONFIG}" ] && RUNCONFIG="opera_pge_dist_s1_r6.0_beta_runconfig.yaml" |
There was a problem hiding this comment.
This will need to be updated to use 2.1 as release version as well
| @@ -446,6 +446,7 @@ def run_postprocessor(self, **kwargs): | |||
| print(f'Running postprocessor for {self._post_mixin_name}') | |||
|
|
|||
| self._validate_outputs() | |||
| self._run_sas_qa_executable() | |||
| # TODO: Should the PGE flatten the output? | ||
|
|
||
| # TODO: Just realized the below loop doesn't really work with the current compare script (but should be kept since | ||
| # I think the compare script should check by band and not whole product) |
There was a problem hiding this comment.
I think its alright to let the SAS validation routine work on a directory (or granule) at time for us if that's what makes the most sense. In the meantime, can we remove the commented out block before this branch is merged?
There was a problem hiding this comment.
I cut out this section.
I did make a feature request for ADT to support comparisons by band (might make it easier for them/us to diagnose issues if something goes wrong) + more descriptive reasons for what is unequal.
Description
Affected Issues
Testing
opera-dev-pge)opera-dev-pge:/home/rileykk/dist-s1-int/)