Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Condition Sets] Gracefully handle no telemetry #7997

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jvigliotta
Copy link
Contributor

Closes #7996

Describe your changes:

If no telemetry is returned, we return undefined, the rest of the code path handles that gracefully.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@jvigliotta jvigliotta self-assigned this Feb 1, 2025
@jvigliotta jvigliotta requested a review from akhenry February 1, 2025 00:17
Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.28%. Comparing base (1fde0d9) to head (0d675c1).

Files with missing lines Patch % Lines
.../plugins/condition/criterion/TelemetryCriterion.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7997      +/-   ##
==========================================
- Coverage   57.62%   57.28%   -0.34%     
==========================================
  Files         678      678              
  Lines       27426    27428       +2     
  Branches     2692     2692              
==========================================
- Hits        15803    15711      -92     
- Misses      11281    11374      +93     
- Partials      342      343       +1     
Flag Coverage Δ
e2e-ci 62.81% <50.00%> (-0.01%) ⬇️
e2e-full 23.65% <0.00%> (-18.36%) ⬇️
unit 49.33% <50.00%> (-0.06%) ⬇️
Files with missing lines Coverage Δ
.../plugins/condition/criterion/TelemetryCriterion.js 77.51% <50.00%> (-0.44%) ⬇️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fde0d9...0d675c1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Condition Sets] Breaking when no telemetry is returned
1 participant