Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ogma-core: Remove incorrect function declaration from template. Refs #240. #241

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

ivanperez-keera
Copy link
Member

Remove incorrect mention of an undefined function split from the cFS template, as prescribed in the solution proposed for #240 .

…asa#240.

The cFS template incorrectly mentions a `split` function that no longer exists.
It left over from a prior version of this application that expected the monitor
handler to be called `split`, which is no longer the case.

This commit removes the declaration of that function from the cFS template.
@ivanperez-keera ivanperez-keera marked this pull request as ready for review February 5, 2025 00:33
@ivanperez-keera
Copy link
Member Author

Change Manager: Verified that:

  • Solution is implemented:
    • The code proposed compiles and passes all tests. Details:
    • The solution proposed produces the expected result. Details:
      The following Dockerfile checks that the function split is no longer mentioned in the cFS app in the template, after which it prints the message "Success":
      FROM ubuntu:focal
      
      RUN apt-get update
      
      RUN apt-get install --yes git
      
      SHELL ["/bin/bash", "-c"]
      CMD git clone $REPO \
          && cd $NAME \
          && git checkout $COMMIT \
          && ! grep -nHre '\<split\>' --include='*.h' --include='*.c' ogma-core/templates \
          && echo "Success"
      Command (substitute variables based on new path after merge):
      $ docker run -e "REPO=https://github.com/ivanperez-keera/ogma" -e "NAME=ogma" -e "BASE_COMMIT=develop" -e "COMMIT=351cb199ee73385f1cb7e6d76d50833ae5470894" -it ogma-verify-240
      
  • Implementation is documented. Details:
    No updates needed; the change removes outdated code.
  • Change history is clear.
  • Commit messages are clear.
  • Changelogs are updated.
  • Examples are updated. Details:
    No updates needed; the change removes outdated code.
  • Author is internal or has provided signed CLA.
  • Required version bumps are evaluated. Details:
    Bump not needed; the change removes outdated code that wasn't needed.

@ivanperez-keera ivanperez-keera merged commit 225cb27 into nasa:develop Feb 5, 2025
2 checks passed
@ivanperez-keera ivanperez-keera deleted the develop-remove-split branch February 5, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant