Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nasa/nos3#498] Vagrant Disk Size #499

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

[nasa/nos3#498] Vagrant Disk Size #499

wants to merge 2 commits into from

Conversation

jlucas9
Copy link
Contributor

@jlucas9 jlucas9 commented Feb 9, 2025

Added line to Vagrantfile to allow extending the size of the VM disk.
Note some additional commands are required and were captured in the FAQ of the ./docs/wiki/Home.md.

Closes #498

Notes on how this was tested prior to merge request are captured in the issue.

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (acae0f5) to head (1a8a5cc).
Report is 34 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #499   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines          2       2           
=====================================
  Misses         2       2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zlynch2
Copy link

zlynch2 commented Feb 10, 2025

Will need to edit to 265 manually

Pulled branch Vagrant up, extended to 64 GB successfully. but getting

"NOCHANGE: partition 3 could only be grown by 2015 [fudge=2048]"

when running growpart /dev/sda 3

still 64 not 256

image

vagrant file still reads config is 64 on branch
" ### General configuration
config.vm.disk :disk, size: "64GB", primary: true"

Copy link

@zlynch2 zlynch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding new vm and increasing disk space to 256 worked using commands (found in issue) works.

also just to reiterate if you only want 64GB, the following also works.

sudo lvextend -l +100%FREE /dev/ubuntu-vg/ubuntu-lv
sudo resize2fs /dev/ubuntu-vg/ubuntu-lv

Approving

@jlucas9
Copy link
Contributor Author

jlucas9 commented Feb 11, 2025

The latest commit added the commands to the vagrant provision to make the process easier for users.

@msuder
Copy link
Contributor

msuder commented Feb 11, 2025

Created new VM. Verified disk size. Extended disk. Verified new disk size. This PR is working as it is supposed to.

Copy link
Contributor

@kevincbruce kevincbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants