Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a checkout application for the generic_thruster component. Have verified the checkout launches and can be commanded in the newest push. The branch is set up so that the top level files should be set up as normal in dev, and thus need to be modified to work the checkout. There was a previous checkout using support, but it was identical to old sample, so I started from scratch. There was also no device.c or device.h, and that functionality was done in the app. I have modified the app to utilize a method in device to access UART, and have set up the device files, with only what code is necessary (I believe). I have tested operation both with YAMCS and the rest of FSW, and with the checkout to ensure it all works, and would encourage others to do the same when testing this.
The only concern I still see:
The sim is slow to connect to 42. Wait, and it eventually will, after spamming out errors failing to connect for a while. I am not sure why it is so slow to connect. May be worth further investigation, but for now, just wait for it to connect before commanding.
Steps:
Enable Thruster in the NOS3 minimal config, switch to using the minimal config in the top level no3 mission config, and uncomment the Thruster part of checkout.sh in scripts.
make clean
make debug
cd components/generic_thruster/fsw/standalone/build
(
mkdir build
in the standalone directory if needed, thencd build
)make clean
(if build directory already exists)cmake .. -DTGTNAME=cpu1
make
exit
make clean
make
make checkout
The following submodule PRs must be merged and updated first:
nasa-itc/generic_thruster#2
Closes #468