Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nasa/nos3#468] thruster checkout #489

Merged
merged 3 commits into from
Feb 8, 2025
Merged

Conversation

kevincbruce
Copy link
Contributor

Added a checkout application for the generic_thruster component. Have verified the checkout launches and can be commanded in the newest push. The branch is set up so that the top level files should be set up as normal in dev, and thus need to be modified to work the checkout. There was a previous checkout using support, but it was identical to old sample, so I started from scratch. There was also no device.c or device.h, and that functionality was done in the app. I have modified the app to utilize a method in device to access UART, and have set up the device files, with only what code is necessary (I believe). I have tested operation both with YAMCS and the rest of FSW, and with the checkout to ensure it all works, and would encourage others to do the same when testing this.

The only concern I still see:

The sim is slow to connect to 42. Wait, and it eventually will, after spamming out errors failing to connect for a while. I am not sure why it is so slow to connect. May be worth further investigation, but for now, just wait for it to connect before commanding.

Steps:

Enable Thruster in the NOS3 minimal config, switch to using the minimal config in the top level no3 mission config, and uncomment the Thruster part of checkout.sh in scripts.

make clean
make debug
cd components/generic_thruster/fsw/standalone/build
(mkdir build in the standalone directory if needed, then cd build)
make clean (if build directory already exists)
cmake .. -DTGTNAME=cpu1
make
exit
make clean
make
make checkout

The following submodule PRs must be merged and updated first:

nasa-itc/generic_thruster#2

Closes #468

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (dev@111eecb). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #489   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?       1           
  Lines          ?       2           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?       2           
  Partials       ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Isgaroth-the-Green Isgaroth-the-Green left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything appears to work as it should. You are right that it takes quite a while for 42 to finally connect, though; I am not sure how best to fix that. Is that a new problem? I thought it was already having that problem in regular NOS3, without even considering the checkout.

Copy link
Contributor

@jlucas9 jlucas9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working for me!

@jlucas9 jlucas9 merged commit 5c7d788 into dev Feb 8, 2025
3 checks passed
@jlucas9 jlucas9 deleted the nos3#468-thruster-checkout branch February 8, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants