Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nasa/nos3#483] Update Deprecated gethostbyname to getaddrinfo #484

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

rjbrown2
Copy link
Member

Modified gethostbyname to getaddrinfo.

Build and test as you normally would.

@rjbrown2 rjbrown2 added the Bug label Jan 30, 2025
@rjbrown2 rjbrown2 self-assigned this Jan 30, 2025
@rjbrown2 rjbrown2 linked an issue Jan 30, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (1b68c6f) to head (5e97de1).

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #484   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines          2       2           
=====================================
  Misses         2       2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjbrown2 rjbrown2 changed the title [nasa/nos3#483] Update Deprecated gethostbyname to getaddrinfo WIP: [nasa/nos3#483] Update Deprecated gethostbyname to getaddrinfo Jan 30, 2025
@rjbrown2
Copy link
Member Author

Seems to be an issue with Cryptolib and its branches.

@jlucas9 jlucas9 changed the title WIP: [nasa/nos3#483] Update Deprecated gethostbyname to getaddrinfo [nasa/nos3#483] Update Deprecated gethostbyname to getaddrinfo Jan 31, 2025
@msuder
Copy link
Contributor

msuder commented Jan 31, 2025

One comment above.

I ran the software and it went to sun point ok.

@rjbrown2
Copy link
Member Author

This should be good to go now.

When you test, please build as normally. Verify sunpoint, and please make sure that commands are showing in both Cryptolib, and FSW Window.

Copy link

@zlynch2 zlynch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in cosmos and yamcs. Note, in cosmos only radio interface works with cryptolib when watching tm and tc printouts, with yamcs it doesnt care. approving

Copy link
Contributor

@Donnie-Ice Donnie-Ice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified CryptoLib and sun point

Copy link
Contributor

@kevincbruce kevincbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran with YAMCS. Verified CryptoLib. ADCS seemed to do things, but seemed there may have been issues with automatic sun point (as if it wasn't sending the adc updates on the scheduler, seemed RW values, for example, would get set right, but not change/reverse, at least without manual input. Though may be an issue with my build of things).

@rjbrown2 rjbrown2 merged commit 111eecb into dev Feb 3, 2025
3 checks passed
@jlucas9 jlucas9 deleted the 483-replace-gethostbyname branch February 8, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Replace gethostbyname
6 participants