-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nasa/nos3#483] Update Deprecated gethostbyname to getaddrinfo #484
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #484 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 1 1
Lines 2 2
=====================================
Misses 2 2 ☔ View full report in Codecov by Sentry. |
Seems to be an issue with Cryptolib and its branches. |
One comment above. I ran the software and it went to sun point ok. |
This should be good to go now. When you test, please build as normally. Verify sunpoint, and please make sure that commands are showing in both Cryptolib, and FSW Window. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in cosmos and yamcs. Note, in cosmos only radio interface works with cryptolib when watching tm and tc printouts, with yamcs it doesnt care. approving
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified CryptoLib and sun point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran with YAMCS. Verified CryptoLib. ADCS seemed to do things, but seemed there may have been issues with automatic sun point (as if it wasn't sending the adc updates on the scheduler, seemed RW values, for example, would get set right, but not change/reverse, at least without manual input. Though may be an issue with my build of things).
Modified gethostbyname to getaddrinfo.
Build and test as you normally would.