Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

https://github.com/nasa/nos3/issues/438 - Reduce scheduled ADCS messa… #479

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

https://github.com/nasa/nos3/issues/438 - Reduce scheduled ADCS messa… #479

wants to merge 4 commits into from

Conversation

msuder
Copy link
Contributor

@msuder msuder commented Jan 24, 2025

…ges from 10Hz to 1Hz.

@msuder msuder self-assigned this Jan 24, 2025
@msuder
Copy link
Contributor Author

msuder commented Jan 24, 2025

To test:
Build and run as normal. Verify that FSW executes RTS 1 and 3 and transitions to mode 2 (sunpoint).

@jlucas9
Copy link
Contributor

jlucas9 commented Jan 27, 2025

Can't seem to get to actual sun pointed in testing

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (dev@1e34337). Learn more about missing BASE report.

Additional details and impacted files 
@@          Coverage Diff          @@
##             dev    #479   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?       1           
  Lines          ?       2           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?       2           
  Partials       ?       0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jlucas9
jlucas9 approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@jlucas9 jlucas9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm successful sun pointing!

image

kevincbruce
kevincbruce approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@kevincbruce kevincbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, saw RTSes run and mode get set, and appeared to sun point over time.

dacarter22
dacarter22 approved these changes Feb 5, 2025
View reviewed changes
Copy link

@dacarter22 dacarter22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified RTS 1 and 3 enable and tested successfully with noop command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlucas9 jlucas9 jlucas9 approved these changes

@kevincbruce kevincbruce kevincbruce approved these changes

@dacarter22 dacarter22 dacarter22 approved these changes

@zlynch2 zlynch2 Awaiting requested review from zlynch2

@Isgaroth-the-Green Isgaroth-the-Green Awaiting requested review from Isgaroth-the-Green

Assignees

@msuder msuder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@msuder @jlucas9 @codecov-commenter @kevincbruce @dacarter22