Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue ID
HARMONY-2001
Description
Converts Points and MultiPoints in geojson files to Polygons and MultiPolygons respectively. This fixes a bug where Harmony was attempting to split Points on the antimeridian as part of geojson normalization, but failing because the underlying splitter library doesn't support Points. This change supports Points and MultiPoints that add a
radius
as well, which EDSC is sending in some cases.Also snuck in a fix to delete
krelay
processes when stopping Harmony.Local Test Steps
Issue a POST request to UAT with the following shapefile
e.g.,
with multipart form parameters
shapefile
andmaxResults
.The request will fail with an error about attempting to convert the provided shapefile.
Now issue the same request to localhost (after starting with this branch).
You should see the request run and create a job. Don't worry about whether or not you have the correct service deployed, this is just to verify that the shapefile normalization handles the geojson.
I have visually inspected the output of the circle polygon generation and it looks right to me. If you want to see this you can just log the output of normalization in one of the new tests and plot that in a geojson viewer like this one https://geojson.tools/.
PR Acceptance Checklist
Documentation updated (if needed)