Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmony 1998 - Add message_category to workflow ui #692

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

vinnyinverso
Copy link
Collaborator

@vinnyinverso vinnyinverso commented Feb 5, 2025

Jira Issue ID

HARMONY-1998

Description

Adds message_category to workflow UI badge display and the ability to filter on it.

Screenshot 2025-02-05 at 2 35 06 PM Screenshot 2025-02-05 at 2 35 32 PM

Local Test Steps

Kick off a job, and edit the message_category for one of the work items in the DB. You should be able to filter on it from the job page of the workflow ui, regardless of what the text is.

PR Acceptance Checklist

  • Acceptance criteria met
  • Tests added/updated (if needed) and passing
  • Documentation updated (if needed)
  • Harmony in a Box tested? (if changes made to microservices)

@vinnyinverso vinnyinverso changed the title Harmony 1998 - Add sub_status to workflow ui Harmony 1998 - Add message_category to workflow ui Feb 5, 2025
@ygliuvt
Copy link
Member

ygliuvt commented Feb 6, 2025

Tested successfully. The only issue I have with the ui is that when filtering on message category, it is implied that the status is warning which might be ok on strict filtering, but it becomes confusing when negate message categories checkbox is checked -- intuition should be returning all work items that don't have the filtered message categories including successful and failed ones, but the ui returned only work items in warning status and not in the filtered message categories without adding the status warning filter automatically. I think the message category should not be tied automatically to warning status. If people want warning items with a certain message category, they can add the status warning filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants