Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ldds 528 #690

Merged
merged 8 commits into from
Feb 11, 2025
Merged

Ldds 528 #690

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4dae336
Adding dimension/band subsetting to ldds/subset-band-name service
Jan 22, 2025
72d9c71
Enabling dimension/band subsetting for subset-band-name in UAT
Feb 4, 2025
d60569b
Merge branch 'main' into LDDS-528
Feb 4, 2025
74778a2
Service chained subset-band-name in geoloco's service and added dimen…
Feb 5, 2025
4f5acc6
Made subset-band-name service image conditional for variable and dime…
Feb 6, 2025
4f03a1f
Merge branch 'main' into LDDS-528
Feb 7, 2025
f3d03b3
Merge branch 'main' into LDDS-528
chris-durbin Feb 10, 2025
383e073
Merge branch 'main' into LDDS-528
Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions config/services.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,6 +624,7 @@ https://cmr.uat.earthdata.nasa.gov:
subsetting:
variable: true
multiple_variable: true
dimension: true
output_formats:
- application/x-hdf
steps:
Expand Down Expand Up @@ -652,12 +653,15 @@ https://cmr.uat.earthdata.nasa.gov:
bbox: true
variable: true
multiple_variable: true
dimension: true
output_formats:
- application/x-hdf
reprojection: true
steps:
- image: !Env ${QUERY_CMR_IMAGE}
is_sequential: true
- image: !Env ${SUBSET_BAND_NAME_IMAGE}
is_sequential: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this one should be marked as sequential. Sequential is for something like query-cmr with pages through CMR results and can possibly create additional work items for the same step as part of its process.

I believe you'll want to make this step optional though. For example if a user does not ask for variable subsetting I think you want to skip subset-band-name and go straight to Geoloco. I'm not sure what other operations subset-band-name performs besides variable subsetting.

Something like:

        conditional:
          exists: ['variableSubset']

Similarly are there ever cases where you would only want to perform Geoloco and not subset-band-name? You would want to add a conditional for it as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the variableSubset include dimension subsetting? Or do I add something like dimensionSubset?

Copy link
Author

@cbrownstevenson cbrownstevenson Feb 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. Found my answer.

- image: !Env ${GEOLOCO_IMAGE}

- name: giovanni-time-series-adapter
Expand Down
Loading