Update nisar-py regression test for nisar-py v0.4.0#290
Merged
Conversation
asjohnston-asf
requested review from
a team,
flamingbear and
owenlittlejohns
as code owners
flamingbear
approved these changes
May 26, 2026
flamingbear
left a comment
flamingbear
left a comment
Member
There was a problem hiding this comment.
Looks good, I was able to verify the old image against SIT at 0.3.0, and this branch against UAT with nisar-py 0.4.0.
❯ ./run_notebooks.sh nisar-py
Running regression tests
Using https://harmony.uat.earthdata.nasa.gov
Test suite nisar-py starting
running test with ghcr.io/nasa/regression-tests-nisar-py:latest
Waiting for nisar-py.
Input Notebook: nisar-py/nisar-py_Regression.ipynb
Output Notebook: /workdir/output/nisar-py/Results.ipynb
Working directory: nisar-py
Executing: 0%| | 0/4 [00:00<?, ?cell/s]Executing notebook with kernel: python3
Executing: 100%|██████████| 4/4 [16:02<00:00, 240.70s/cell]
Test suite nisar-py succeeded
Tests completed (passed)
flamingbear
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
nisar-py v0.4.0 now applies a valid data mask so that that invalid and partially focused pixels are set to NoData in the output imagery. This results in needing to update the md5sums for the majority of output .png files.
For those interested in comparing the expected output, these harmony UAT jobs were run using nisar-py v0.4.0:
And these harmony UAT jobs were run using the previous nisar-py v0.3.0:
Jira Issue ID
Local Test Steps
PR Acceptance Checklist
Documentation updated (if needed)version.txtfile changed if appropriateOriginal file is uploaded to S3 if references are changed