Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HARMONY-1898: As harmony-py user, I want to be able add one or more labels to one or more of my jobs #102

Merged
merged 5 commits into from
Feb 7, 2025

Conversation

ygliuvt
Copy link
Member

@ygliuvt ygliuvt commented Feb 5, 2025

Jira Issue ID

HARMONY-1898

Description

As harmony-py user, I want to be able add one or more labels to one or more of my jobs

Local Test Steps

Run labels notebook and verify adding labels to jobs work as expected.
Verify readthedocs documentation is ok.

PR Acceptance Checklist

  • Acceptance criteria met
  • Tests added/updated (if needed) and passing
  • Documentation updated (if needed)

@ygliuvt ygliuvt force-pushed the harmony-1898-1 branch 2 times, most recently from 6c5baa8 to 796908b Compare February 5, 2025 23:38
Copy link
Contributor

@chris-durbin chris-durbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully, I like the refactor to BaseRequest. I also verified we have a separate ticket for removing labels from jobs.

Copy link
Contributor

@indiejames indiejames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment about the http_method parameter.

harmony/harmony.py Outdated Show resolved Hide resolved
Copy link
Contributor

@indiejames indiejames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested code changes - looks good

@ygliuvt ygliuvt merged commit 956807b into main Feb 7, 2025
11 checks passed
@ygliuvt ygliuvt deleted the harmony-1898-1 branch February 7, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants