-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAS-2256 update earthdata-varinfo version 3.0.0 #25
Conversation
@@ -265,19 +227,19 @@ | |||
}, | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this section does not need to be updated. The attributes can remain as float 0.0 and 90.0
The examples in https://cfconventions.org/Data/cf-conventions/cf-conventions-1.7/build/apf.html are in float
The changes are unrelated to varinfo update.
hoss/hoss_config.json
Outdated
}, | ||
{ | ||
"Applicability": { | ||
"Mission": "MERRA-2", | ||
"Variable_Pattern": "/lat" | ||
"VariablePattern": "/lat" | ||
}, | ||
"Attributes": [ | ||
{ | ||
"Name": "valid_range", | ||
"Value": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this needs to be updated either
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of migrating to earthdata-varinfo 3.0.0 is to
Removing underscores in JSON schema attribute names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. I'm having a couple of issues with my local Harmony instance, so I was not able to test these changes out locally using the notebooks you mentioned (although those are great test instructions).
I did run the new version of hoss_config.json
through jsonschema to ensure that it was compliant with the schema definition, which it was. Nice.
I also locally built the service and test image to confirm that the unit tests worked as expected (I had to add --platform linux/amd64
to the docker build
and docker run
commands, so that might be a change that should be made in a future PR)
pip_requirements.txt
Outdated
@@ -1,6 +1,6 @@ | |||
# This file should contain requirements to be installed via Pip. | |||
# Open source packages available from PyPI | |||
earthdata-varinfo ~= 2.3.0 | |||
earthdata-varinfo ~= 3.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Not a blocker) Might as well bump this directly to 3.0.1, which is the latest version. (The difference between 3.0.0 and 3.0.1 won't have any impact on this PR, but the ~=
operator will resolve the dependency version to 3.0.1 anyway)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will update to 3.0.1
@@ -690,192 +661,203 @@ | |||
{ | |||
"Applicability": { | |||
"Mission": "GEDI", | |||
"ShortNamePath": "GEDI_L[1234][AB]|GEDI0[1234]_[AB]" | |||
"ShortNamePath": "GEDI_L[1234][AB]|GEDI0[1234]_[AB]", | |||
"VariablePattern": "/$" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch - this was a tricky bit that took a bit more care when converting over the other services.
I was able to run all the notebooks and they all passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit tests all passed. Having some harmony-in-a-box issues that are preventing me from running all the notebooks.
CHANGELOG.md
Outdated
## v1.1.2 | ||
### 2025-01-20 | ||
|
||
- [[DAS-2287](https://bugs.earthdata.nasa.gov/browse/DAS-2287)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the text and link to DAS-2256 instead of DAS-2287
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do
Description
Update HOSS (hoss_config.json) to work with earthdata-varinfo version 3.0.0
Jira Issue ID
https://bugs.earthdata.nasa.gov/browse/DAS-2256
Local Test Steps
Local MAC M1
Build harmony-opendap-subsetter
Start harmony in box if installed on system
Open /<your_workspace>/das-collections-harmony-testing.folder in VSCode and run below tests using Jupiter notebook
Python Environment: hoss_tests
Verify above tests all PASS
PR Acceptance Checklist
CHANGELOG.md
updated to include high level summary of PR changes.docker/service_version.txt
updated if publishing a release.