Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAS-2293: update version/changelog/collections for SPL2SMA #17

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

flamingbear
Copy link
Member

@flamingbear flamingbear commented Feb 5, 2025

Description

Adds SPL2SMA to the smap-l2-gridder

Jira Issue ID

DAS-2293

Local Test Steps

Pull, build and test this branch:

❯ ./bin/build-image && ./bin/build-test && ./bin/run-test

Bump the memory on your docker desktop and in harmony the test case uses just over 20Gi and I have my docker desktop allocated 27Gi and the service 24Gi.
HARMONY_SMAP_L2_GRIDDER_LIMITS_MEMORY=24Gi

Run this request against your Harmony-In-A-Box

http://localhost:3000/C1268429729-EEDTEST/ogc-api-coverages/1.0.0/collections/parameter_vars/coverage/rangeset?forceAsync=true&outputcrs=EPSG%3A4326&granuleId=G1268429743-EEDTEST&format=application%2Fx-netcdf4&variable=all

Download the results to a working directory.

SMAP_L2_SM_A_01058_D_20150413T220200_R13080_001_regridded.nc

Follow the instructions on the Validate-DAS-2293.ipynb notebook (or read the pdf output). Both are attached to the ticket.

PR Acceptance Checklist

  • Jira ticket acceptance criteria met.
  • CHANGELOG.md updated to include high level summary of PR changes.
  • docker/service_version.txt updated if publishing a release.
  • [N/A] Tests added/updated and passing.
  • [N/A] Documentation updated (if needed).

@flamingbear flamingbear marked this pull request as ready for review February 5, 2025 20:12
@flamingbear flamingbear requested review from owenlittlejohns and a team February 5, 2025 20:12
Copy link
Member

@owenlittlejohns owenlittlejohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. I ran through all the test instructions, including the validation notebook, and it all made sense. Nice work.

As mentioned in Slack, I also like the renaming of the dropped_variables to more align with vocabulary from earthdata-varinfo.

@flamingbear flamingbear merged commit ef12127 into main Feb 6, 2025
8 checks passed
@flamingbear flamingbear deleted the mhs/DAS-2293/add-SPL2SMA branch February 6, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants