fix(rjsf): remove debounce #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benforshey
commented
Jan 23, 2025
There was a problem hiding this comment.
Removes debounce and its documentation.
joncarlson
requested review from
joncarlson
and removed request for
joncarlson
joncarlson
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the RJSF's debounce. The effect on large forms is that the UI hangs a bit on blur when moving from one input to another. Previously, for models that used the large form option, if it wasn't actually a very large model (I only tested Collection Metadata) it would sometimes fail to write text and sometimes fail to erase text on blur. Removing the debounce seems to fix this, but it also makes advancing the cursor to another input hang for a second on large models while it validates. This happens less with ajv8 6 alpha, but it still happens.