-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/meditor 829 codepipeline #51
Conversation
@@ -0,0 +1,12 @@ | |||
# Changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we all agreed to use this file to keep record of updates in each versions? I know there were conversations for using Changelog file. Just wanted to make sure :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joncarlson Any thoughts on manual changelogs, automated changelogs, checklists, etc (from our other PR conversation)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My one reservation about changelogs is that historically they have not been kept up to date, which is why we haven't implemented them in mEditor.
So the question is, if we start adding changelogs, how do we ensure they stay updated? Having a checklist, or even better, a merge check, would go along way to making sure the changelog is actually useful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that a checklist / merge check seems like a really good way to remind people to update tests and documentation. I'd fully support that for all our repos, so I'll make a note to discuss this on Thursday.
This is awesome, so much better than running shell scripts locally! |
This PR adds two features related to our AWS Deployment Pipeline:
package.json
's version for use in CodeBuild