Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/meditor 829 codepipeline #51

Merged
merged 6 commits into from
Apr 9, 2024

Conversation

benforshey
Copy link
Contributor

This PR adds two features related to our AWS Deployment Pipeline:

  1. adds a bash script to get the root package.json's version for use in CodeBuild
  2. adds ARG to the two Dockerfiles that didn't have it; we pull images from ECR when building with Docker to prevent a 429 response

@@ -0,0 +1,12 @@
# Changelog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we all agreed to use this file to keep record of updates in each versions? I know there were conversations for using Changelog file. Just wanted to make sure :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joncarlson Any thoughts on manual changelogs, automated changelogs, checklists, etc (from our other PR conversation)?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My one reservation about changelogs is that historically they have not been kept up to date, which is why we haven't implemented them in mEditor.

So the question is, if we start adding changelogs, how do we ensure they stay updated? Having a checklist, or even better, a merge check, would go along way to making sure the changelog is actually useful

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that a checklist / merge check seems like a really good way to remind people to update tests and documentation. I'd fully support that for all our repos, so I'll make a note to discuss this on Thursday.

@joncarlson
Copy link
Collaborator

This is awesome, so much better than running shell scripts locally!

@benforshey benforshey merged commit 84f21fd into main Apr 9, 2024
5 checks passed
@benforshey benforshey deleted the feature/MEDITOR-829-codepipeline branch April 9, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants