Truncate assert path#5141
Open
bevinduckett wants to merge 6 commits into
Open
Conversation
Added the file path leading-truncation for the log() message from reportAssert() and added unit test coverage. Updated the truncation for the file path from the event argument to be leading-truncation (not trailing truncation) Added custom config to the unit test so that file path truncation would be tested (custom configuration)
Removed the config override that was being done for the AssertFatalAdaptor UT and instead updated AssertFatalAdapterEventFileSize in default/config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Rationale
See feature rationale in #5122
Testing/Review Recommendations
Future Work
We could consider adding a function to StringUtils to do leading-truncation
AI Usage (see policy)
AI (Claude code, Sonnet 4.5) was used to assist with the unit test updates