FpySequencer SEQ_BASE_DIR parameter#5074
Open
zimri-leisher wants to merge 7 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Fw::ParamValid valid; | ||
| Fw::ParamString baseDir = this->paramGet_SEQ_BASE_DIR(valid); | ||
| if (baseDir.length() > 0) { | ||
| this->m_sequenceFilePath.format("%s/%s", baseDir.toChar(), value.get_filePath().toChar()); |
| Fw::ParamValid valid; | ||
| Fw::ParamString baseDir = this->paramGet_SEQ_BASE_DIR(valid); | ||
| if (baseDir.length() > 0) { | ||
| this->m_sequenceFilePath.format("%s/%s", baseDir.toChar(), value.get_filePath().toChar()); |
| if (baseDir.length() > 0) { | ||
| this->m_sequenceFilePath.format("%s/%s", baseDir.toChar(), value.get_filePath().toChar()); | ||
| } else { | ||
| this->m_sequenceFilePath = value.get_filePath(); |
| if (baseDir.length() > 0) { | ||
| this->m_sequenceFilePath.format("%s/%s", baseDir.toChar(), value.get_filePath().toChar()); | ||
| } else { | ||
| this->m_sequenceFilePath = value.get_filePath(); |
LeStarch
requested changes
May 5, 2026
| Fw::ParamValid valid; | ||
| Fw::ParamString baseDir = this->paramGet_SEQ_BASE_DIR(valid); | ||
| if (baseDir.length() > 0) { | ||
| this->m_sequenceFilePath.format("%s/%s", baseDir.toChar(), value.get_filePath().toChar()); |
Collaborator
There was a problem hiding this comment.
You must check the return status of the format function as without it you may get a completely botched path.
| } | ||
|
|
||
| TEST_F(FpySequencerTester, seqBaseDir_resolvesPath) { | ||
| // base dir of "." should resolve "test.bin" to "./test.bin" — m_sequenceFilePath |
Collaborator
There was a problem hiding this comment.
I don't know that this actually tests what you want. To file open, "./test.bin" and "test.bin" mean the same thing. Thus it doesn't test that the prefix works. We should use instead ../<current_dir>/test.bin
| ASSERT_TLM_PRM_SEQ_BASE_DIR_SIZE(1); | ||
| ASSERT_TLM_PRM_SEQ_BASE_DIR(0, val.toChar()); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Probably want an absolute path test too (using pwd or something) because this will be the most frequent use-case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
AI Usage (see policy)