Fixes #1708 by Completing the work In Fw
#3173
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| } | ||
| return formatStatus; | ||
| } |
Check warning
Code scanning / CppCheck
Could not find a newline character at the end of the file. Warning
| if (status < 0) { | ||
| buffer[0] = 0; | ||
| } | ||
| #if FW_OBJECT_TO_STRING == 1 |
Check notice
Code scanning / CodeQL
Conditional compilation Note
|
|
||
| namespace Fw { | ||
|
|
||
| PassiveComponentBase::PassiveComponentBase(const char* name) : Fw::ObjBase(name), m_idBase(0), m_instance(0) { | ||
| } | ||
|
|
||
| #if FW_OBJECT_TO_STRING == 1 && FW_OBJECT_NAMES == 1 | ||
| #if FW_OBJECT_TO_STRING == 1 |
Check notice
Code scanning / CodeQL
Conditional compilation Note
| if (status < 0) { | ||
| Fw::FormatStatus status = Fw::ExternalString(buffer, static_cast<Fw::ExternalString::SizeType>(size)).format( | ||
| this->getToStringFormatString(), | ||
| #if FW_OBJECT_NAMES == 1 |
Check notice
Code scanning / CodeQL
Conditional compilation Note
| if (status < 0) { | ||
| buffer[0] = 0; | ||
| } | ||
| #if FW_OBJECT_TO_STRING == 1 |
Check notice
Code scanning / CodeQL
Conditional compilation Note
| const char* formatString = this->getToStringFormatString(); | ||
| // Determine this port object name (or use "UNKOWN") | ||
| const char* object_name = | ||
| #if FW_OBJECT_NAMES == 1 |
Check notice
Code scanning / CodeQL
Conditional compilation Note
|
|
||
| // Get the name of the connectioned object, "UNKNNOWN" or "NONE" | ||
| const char* connected_to = this->isConnected() ? | ||
| #if FW_OBJECT_NAMES == 1 |
Check notice
Code scanning / CodeQL
Conditional compilation Note
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
| // \brief cpp file for c-string format function as a implementation using snprintf | ||
| // | ||
| // \copyright | ||
| // Copyright (C) 2025 California Institute of Technology. |
There was a problem hiding this comment.
I believe we are not supposed to add those copyright notices anymore?
Change Description
This completes the work for #1708 by updating
Fw.