Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GoogleTest as a submodule #2371

Merged
merged 6 commits into from
Nov 27, 2023
Merged

Use GoogleTest as a submodule #2371

merged 6 commits into from
Nov 27, 2023

Conversation

thomas-bc
Copy link
Collaborator

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s) #1998
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Added googletest as a submodule, at v1.14.0. The repo won't be cloned at generation time anymore, but use the submodule instead.

Rationale

See #1998 and #1819

Testing/Review Recommendations

CI

@thomas-bc thomas-bc requested a review from LeStarch November 15, 2023 20:11
@thomas-bc
Copy link
Collaborator Author

Oops -- all the CI is failing because actions/checkout doesn't checkout submodules by default 🥲

@thomas-bc
Copy link
Collaborator Author

  • updated the workflows to submodule: true. submodule: recursive technically would allow external code to be ran and is therefore not used
  • moved submodule to ./googletest
  • using add_subdirectory() to build googletest

LeStarch
LeStarch approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@LeStarch LeStarch merged commit b9551a2 into nasa:devel Nov 27, 2023
34 checks passed
@thomas-bc thomas-bc mentioned this pull request Nov 27, 2023
Merged
@LeStarch LeStarch added the Update Instructions Needed Need to add instructions in the release notes for updates. label Nov 29, 2023
@thomas-bc thomas-bc deleted the gtest-submodule branch June 25, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeStarch LeStarch LeStarch approved these changes

Assignees
No one assigned
Labels
Update Instructions Needed Need to add instructions in the release notes for updates.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomas-bc @LeStarch