Static analysis checks

nasa · Jan 25, 2024 · dcecdb2 · dcecdb2
1 parent b14032f
commit dcecdb2
Show file tree

Hide file tree

Showing 7 changed files with 28 additions and 15 deletions.
diff --git a/Os/File.cpp b/Os/File.cpp
@@ -137,7 +137,7 @@ File::Status File::write(const void* buffer, FwSignedSizeType &size, bool wait)
     return this->writeInternal(buffer, size, wait);
 }
 
-File::CrcWorkingSet::CrcWorkingSet() : m_crc(INITIAL_CRC), m_eof(false) {}
+File::CrcWorkingSet::CrcWorkingSet() : m_offset(0), m_crc(INITIAL_CRC), m_buffer(), m_eof(false) {}
 
 File::Status File::updateCRC(Os::File::CrcWorkingSet& data, bool nice) {
     FwSignedSizeType size = sizeof data.m_buffer;

diff --git a/Os/Posix/errno.hpp b/Os/Posix/errno.hpp
@@ -18,4 +18,4 @@ File::Status errno_to_file_status(PlatformIntType errno_input);
 
 }
 }
-#endif
+#endif
diff --git a/Os/test/ut/file/CommonTests.cpp b/Os/test/ut/file/CommonTests.cpp
@@ -1,8 +1,12 @@
+// ======================================================================
+// \title Os/test/ut/file/CommonFileTests.cpp
+// \brief common test implementations
+// ======================================================================
 #include "Os/test/ut/file/CommonTests.hpp"
 #include <gtest/gtest.h>
 #include "Os/File.hpp"
 
-const static U32 RANDOM_BOUND = 1000;
+static const U32 RANDOM_BOUND = 1000;
 
 Functionality::Functionality() : tester(Os::Test::File::get_tester_implementation()) {}
 

diff --git a/Os/test/ut/file/CommonTests.hpp b/Os/test/ut/file/CommonTests.hpp
@@ -1,5 +1,5 @@
 // ======================================================================
-// \title Os/test/ut/CommonFileTests.hpp
+// \title Os/test/ut/file/CommonFileTests.hpp
 // \brief definitions used in common file testing
 // ======================================================================
 #include <Os/File.hpp>
@@ -29,10 +29,10 @@ class Functionality : public ::testing::Test {
     Functionality();
 
     //! Setup function delegating to UT setUp function
-    virtual void SetUp() override;
+    void SetUp() override;
 
     //! Setup function delegating to UT tearDown function
-    virtual void TearDown() override;
+    void TearDown() override;
 
     //! Tester/state implementation
     std::unique_ptr<Os::Test::File::Tester> tester;
@@ -48,7 +48,7 @@ class InvalidArguments : public Functionality {};
 class FunctionalIO : public Functionality {
 
     //! Specialized setup method used to pass requirement for functional i/o
-    virtual void SetUp() override;
+    void SetUp() override;
 };
 
 #endif  // OS_TEST_UT_COMMON_FILE_TESTS_HPP
diff --git a/Os/test/ut/file/MyRules.cpp b/Os/test/ut/file/MyRules.cpp
@@ -1,4 +1,7 @@
-
+// ======================================================================
+// \title Os/test/ut/file/MyRules.cpp
+// \brief rule implementations for common testing
+// ======================================================================
 
 #include "RulesHeaders.hpp"
 #include "STest/Pick/Pick.hpp"

diff --git a/Os/test/ut/file/MyRules.hpp b/Os/test/ut/file/MyRules.hpp
@@ -1,4 +1,7 @@
-
+// ======================================================================
+// \title Os/test/ut/file/MyRules.hpp
+// \brief rule definitions for common testing
+// ======================================================================
 // Stripped when compiled, here for IDEs
 #include "RulesHeaders.hpp"
 
@@ -38,7 +41,7 @@ struct OpenFileCreate : public OpenBaseRule {
     // ----------------------------------------------------------------------
 
     //! Constructor
-    OpenFileCreate(const bool randomize_filename = false);
+    explicit OpenFileCreate(const bool randomize_filename = false);
 };
 
 // ------------------------------------------------------------------------------------------------------
@@ -51,7 +54,7 @@ struct OpenFileCreateOverwrite : public OpenBaseRule {
     // ----------------------------------------------------------------------
 
     //! Constructor
-    OpenFileCreateOverwrite(const bool randomize_filename = false);
+    explicit OpenFileCreateOverwrite(const bool randomize_filename = false);
 };
 
 
@@ -65,7 +68,7 @@ struct OpenForWrite : public OpenBaseRule {
     // ----------------------------------------------------------------------
 
     //! Constructor
-    OpenForWrite(const bool randomize_filename = false);
+    explicit OpenForWrite(const bool randomize_filename = false);
 };
 
 // ------------------------------------------------------------------------------------------------------
@@ -78,7 +81,7 @@ struct OpenForRead : public OpenBaseRule {
     // ----------------------------------------------------------------------
 
     //! Constructor
-    OpenForRead(const bool randomize_filename = false);
+    explicit OpenForRead(const bool randomize_filename = false);
 };
 
 // ------------------------------------------------------------------------------------------------------
@@ -441,7 +444,7 @@ struct AssertRule : public STest::Rule<Os::Test::File::Tester> {
     // ----------------------------------------------------------------------
 
     //! Constructor
-    AssertRule(const char *name);
+    explicit AssertRule(const char *name);
 
     // ----------------------------------------------------------------------
     // Public member functions

diff --git a/Os/test/ut/file/RulesHeaders.hpp b/Os/test/ut/file/RulesHeaders.hpp
@@ -1,4 +1,7 @@
-
+// ======================================================================
+// \title Os/test/ut/file/RulesHeaders.hpp
+// \brief rule definitions for common testing
+// ======================================================================
 
 #ifndef __RULES_HEADERS__
 #define __RULES_HEADERS__
-Original file line number
+Diff line change
@@ Expand Up @@
     }
     }
-    #endif
+    #endif