Skip to content

Commit

Permalink
More build fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
LeStarch committed Apr 26, 2024
1 parent 66a58f5 commit d974342
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions Drv/LinuxGpioDriver/LinuxGpioDriverComponentImplStub.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ namespace Drv {
return false;
}

Os::Task::TaskStatus LinuxGpioDriverComponentImpl ::
startIntTask(NATIVE_UINT_TYPE priority, NATIVE_UINT_TYPE stackSize, NATIVE_UINT_TYPE cpuAffinity) {
return Os::Task::TASK_OK;
Os::Task::Status LinuxGpioDriverComponentImpl ::
startIntTask(Os::Task::ParamType priority, Os::Task::ParamType stackSize, Os::Task::ParamType cpuAffinity) {
return Os::Task::OP_OK;
}

LinuxGpioDriverComponentImpl ::
Expand Down
8 changes: 4 additions & 4 deletions Drv/LinuxUartDriver/LinuxUartDriver.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ void LinuxUartDriver ::serialReadTaskEntry(void* ptr) {
status = RecvStatus::RECV_ERROR;
comp->recv_out(0, buff, status);
// to avoid spinning, wait 50 ms
Os::Task::delay(50);
Os::Task::delay(Fw::Time(0, 50));

Check warning

Code scanning / CodeQL

Unchecked return value Warning

The return value of non-void function
delay
is not checked.
continue;
}

Expand Down Expand Up @@ -392,16 +392,16 @@ void LinuxUartDriver ::serialReadTaskEntry(void* ptr) {
void LinuxUartDriver ::start(Os::Task::ParamType priority, Os::Task::ParamType stackSize, Os::Task::ParamType cpuAffinity) {

Check notice

Code scanning / CodeQL

Use of basic integral type Note

priority uses the basic integral type unsigned long rather than a typedef with size and signedness.

Check notice

Code scanning / CodeQL

Use of basic integral type Note

stackSize uses the basic integral type unsigned long rather than a typedef with size and signedness.

Check notice

Code scanning / CodeQL

Use of basic integral type Note

cpuAffinity uses the basic integral type unsigned long rather than a typedef with size and signedness.
Os::TaskString task("SerReader");
Os::Task::Arguments arguments(task, serialReadTaskEntry, this, priority, stackSize, cpuAffinity);

Check warning

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter priority has not been checked.

Check warning

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter stackSize has not been checked.

Check warning

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter cpuAffinity has not been checked.
Os::Task::TaskStatus stat = this->m_readTask.start(arguments);
Os::Task::Status stat = this->m_readTask.start(arguments);
FW_ASSERT(stat == Os::Task::OP_OK, stat);
}

void LinuxUartDriver ::quitReadThread() {
this->m_quitReadThread = true;
}

Os::Task::TaskStatus LinuxUartDriver ::join(void** value_ptr) {
return m_readTask.join(value_ptr);
Os::Task::Status LinuxUartDriver ::join() {
return m_readTask.join();
}

} // end namespace Drv
2 changes: 1 addition & 1 deletion Drv/LinuxUartDriver/LinuxUartDriver.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ class LinuxUartDriver : public LinuxUartDriverComponentBase {
void quitReadThread();

//! Join thread
Os::Task::TaskStatus join(void** value_ptr);
Os::Task::Status join();

//! Destroy object LinuxUartDriver
//!
Expand Down

0 comments on commit d974342

Please sign in to comment.