Fixes nasa/fprime#3174 by fixing interanl and JSON large number handling #190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This fixes the big number (and other so called invalid) JSON object handling by pulling the
JSON.parse
andJSON.stringify
implementations into a custom parser that intercepts the calls.This parser replaces bad tokens with a custom object representation of the item, and then uses the
replacer
andreviver
functions to restore the correct value.Rationale
JSON.parse
cannot handle BigInt, NaN, Infinite, and null. This side steps the issue by performing string manipulation to and from a looser specification, then using JSON, and then restoring the values from.Testing/Review Recommendations
Try to break it with input from the box.
Future Work
Note any additional work that will be done relating to this issue.