Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade spelling workflow #189

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Conversation

thomas-bc
Copy link
Collaborator

Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

v0.20 was using deprecated actions which GitHub now forbids to run. Upgrading to v0.24

thomas-bc and others added 3 commits January 30, 2025 12:52
check-spelling run (push) for spelling-workflow-upgrade

Signed-off-by: check-spelling-bot <[email protected]>
on-behalf-of: @check-spelling <[email protected]>
@thomas-bc thomas-bc requested a review from LeStarch January 30, 2025 20:58
@thomas-bc
Copy link
Collaborator Author

Spelling workflow fails because it uses the old definition from the core repo. It does succeed when ran in my branch https://github.com/thomas-bc/fprime-gds/tree/spelling-workflow-upgrade

I recommend merging despite the failure here

@thomas-bc thomas-bc merged commit edef829 into nasa:devel Jan 30, 2025
10 of 11 checks passed
@thomas-bc thomas-bc deleted the spelling-workflow-upgrade branch January 30, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants