Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spaces from CmdData::get_str(). Fixes #2925 #186

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

AlesKus
Copy link
Contributor

@AlesKus AlesKus commented Jan 12, 2025

Related Issue(s) nasa/fprime#2925
Has Unit Tests (y/n) y
Documentation Included (y/n) n

Change Description

Removed " ".join from CmdData::get_str().
Added some simple unit tests to ensure it works.

Rationale

Fix nasa/fprime#2925.

Testing/Review Recommendations

Same as in the issue description:

  1. Run the Ref example
  2. Execute a command with a string argument
  3. Look at command.log

There should be no spaces in the args section.

Future Work

N/A

Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is an improvement. It does rely on each argument converting cleanly to a string. So we will need to watch on complex types to ensure they work correctly.

@LeStarch
Copy link
Collaborator

Works as expected with complex types.

@LeStarch LeStarch merged commit b4c4122 into nasa:devel Jan 16, 2025
11 checks passed
@AlesKus AlesKus deleted the issue-2925 branch January 16, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command log text arguments have spaces
2 participants