Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes nasa/fprime#3086. Default to insertion order for chrono hist #184

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

LeStarch
Copy link
Collaborator

@LeStarch LeStarch commented Dec 19, 2024

Chronological history needs to default to insertion order when the timestamps of the items are identical. This is fixed by changing the < to <= when comparing timestamps for "older" items.

Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

Fixes nasa/fprime#3086

LeStarch and others added 2 commits December 19, 2024 13:20
Chronological history needs to default to insertion order when the
timestamps of the items are identical. This is fixed by changing
the < to <= when comparing timestamps for "older" items.
Copy link
Collaborator

@kevin-f-ortega kevin-f-ortega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@kevin-f-ortega kevin-f-ortega merged commit e6522f2 into nasa:devel Dec 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Test API] Events With the Same Timestamp Get Miss-ordered by Chronological History
2 participants