Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes nasa/fprime#2654 #171

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Fixes nasa/fprime#2654 #171

merged 1 commit into from
Apr 1, 2024

Conversation

LeStarch
Copy link
Collaborator

@LeStarch LeStarch commented Apr 1, 2024

Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

Fixes nasa/fprime#2654:

  1. Only check port availability if "server"
  2. Trap OSError and recast as ValueError per expected check_arguments API

Future Work

This type of error isn't so much an "argument error" as it is a "runtime error". We should allow check_arguments to produce two types of exceptions one that is an argument error and prints help, the other that just prints the error.

@LeStarch LeStarch requested a review from thomas-bc April 1, 2024 16:39
@thomas-bc thomas-bc merged commit c7348d3 into nasa:devel Apr 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

F´ GDS Issues
2 participants