Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetry packet specifiers to the FPP spec #570

Merged
merged 11 commits into from
Jan 21, 2025
Merged

Conversation

bocchino
Copy link
Collaborator

Closes #564.

I'll schedule a meeting to go over the proposed changes to the spec.

@bocchino
Copy link
Collaborator Author

bocchino commented Jan 17, 2025

Review on January 16, 2025

Here is a summary of the action items and their status.

Item Status
In the User's Guide, make sure to explain how module qualification works Added a note to the issue on updating the User's Guide: #568
In section 7.16, fix typo: telemetry-channel-sequence should be telemetry-channel-identifier-sequence Done
Allow include specifiers in packet specifiers and packet group specifiers Done
In the next version of the packet spec, add a capability to send out specified packets on specified cycles See #573

@bocchino
Copy link
Collaborator Author

I have addressed all the comments from the in-person review. See the summary table above.

@bocchino bocchino merged commit 9ef879c into main Jan 21, 2025
11 checks passed
@bocchino bocchino deleted the issue-564-packet-spec branch January 21, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add telemetry packets to the spec
2 participants