Revise banner comments in generated C++ code #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeStarch
approved these changes
Dec 11, 2023
|
The new output looks correct as shown in the updated UT correctness files. |
This reverts commit 4c76a52. Reverting the change to the test script. This change was trying to be more precise about when to replace the author text in the comment. However, the interaction between CI and the pattern matching does not work as expected. Reverting to the less precise pattern. This pattern should work, because the script is called only when the author needs to be replaced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some issues with the banner comments in the generated "template" files for component implementations and unit test code.
Incorporating this as a "hot fix" against v2.0.1 because it is a small change, and it will be useful to include this in the upcoming point release of F Prime.
Closes #360.