Revise basic test

Exercise name generation outside of topology namespace
nasa · Nov 19, 2024 · 7c64ff0 · 7c64ff0
1 parent 46a2b58
commit 7c64ff0
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 34 deletions.
diff --git a/compiler/tools/fpp-to-cpp/test/top/BasicTopologyAc.ref.cpp b/compiler/tools/fpp-to-cpp/test/top/BasicTopologyAc.ref.cpp
@@ -10,12 +10,6 @@
 // Component instances
 // ----------------------------------------------------------------------
 
-namespace M {
-
-  M::Active active1(FW_OPTIONAL_NAME("active1"));
-
-}
-
 namespace M {
   Active active2;
 
@@ -39,6 +33,8 @@ namespace M {
 
 }
 
+M::Active active1(FW_OPTIONAL_NAME("active1"));
+
 namespace M {
 
 
@@ -60,19 +56,19 @@ namespace M {
   // ----------------------------------------------------------------------
 
   void initComponents(const TopologyState& state) {
-    M::active1.init(QueueSizes::M_active1, InstanceIds::M_active1);
     M::active2.initSpecial();
     M::active3.init(QueueSizes::M_active3, InstanceIds::M_active3);
     M::passive1.init(InstanceIds::M_passive1);
     M::passive2.init(InstanceIds::M_passive2);
+    active1.init(QueueSizes::active1, InstanceIds::active1);
   }
 
   void configComponents(const TopologyState& state) {
     M::active2.config();
   }
 
   void setBaseIds() {
-    M::active1.setIdBase(BaseIds::M_active1);
+    active1.setIdBase(BaseIds::active1);
     M::active2.setIdBase(BaseIds::M_active2);
     M::active3.setIdBase(BaseIds::M_active3);
     M::passive1.setIdBase(BaseIds::M_passive1);
@@ -84,7 +80,7 @@ namespace M {
     // C1
     M::passive1.set_p_OutputPort(
         0,
-        M::active1.get_p_InputPort(0)
+        active1.get_p_InputPort(0)
     );
 
     // C2
@@ -107,31 +103,31 @@ namespace M {
   }
 
   void startTasks(const TopologyState& state) {
-    M::active1.start(
-      static_cast<Os::Task::ParamType>(Priorities::M_active1),
-      static_cast<Os::Task::ParamType>(StackSizes::M_active1),
-      static_cast<Os::Task::ParamType>(CPUs::M_active1),
-      static_cast<Os::Task::ParamType>(TaskIds::M_active1)
-    );
     M::active2.startSpecial();
     M::active3.start(
       Os::Task::TASK_DEFAULT, // Default priority
       Os::Task::TASK_DEFAULT, // Default stack size
       Os::Task::TASK_DEFAULT, // Default CPU
       static_cast<Os::Task::ParamType>(TaskIds::M_active3)
     );
+    active1.start(
+      static_cast<Os::Task::ParamType>(Priorities::active1),
+      static_cast<Os::Task::ParamType>(StackSizes::active1),
+      static_cast<Os::Task::ParamType>(CPUs::active1),
+      static_cast<Os::Task::ParamType>(TaskIds::active1)
+    );
   }
 
   void stopTasks(const TopologyState& state) {
-    M::active1.exit();
     M::active2.stopSpecial();
     M::active3.exit();
+    active1.exit();
   }
 
   void freeThreads(const TopologyState& state) {
-    (void) M::active1.ActiveComponentBase::join();
     M::active2.freeSpecial();
     (void) M::active3.ActiveComponentBase::join();
+    (void) active1.ActiveComponentBase::join();
   }
 
   void tearDownComponents(const TopologyState& state) {

diff --git a/compiler/tools/fpp-to-cpp/test/top/BasicTopologyAc.ref.hpp b/compiler/tools/fpp-to-cpp/test/top/BasicTopologyAc.ref.hpp
@@ -15,13 +15,6 @@
 // Component instances
 // ----------------------------------------------------------------------
 
-namespace M {
-
-  //! active1
-  extern M::Active active1;
-
-}
-
 namespace M {
 
   //! active2
@@ -50,6 +43,9 @@ namespace M {
 
 }
 
+//! active1
+extern M::Active active1;
+
 namespace M {
 
   // ----------------------------------------------------------------------
@@ -67,7 +63,7 @@ namespace M {
 
   namespace BaseIds {
     enum {
-      M_active1 = 0x100,
+      active1 = 0x100,
       M_active2 = 0x200,
       M_active3 = 0x300,
       M_passive1 = 0x300,
@@ -77,45 +73,45 @@ namespace M {
 
   namespace CPUs {
     enum {
-      M_active1 = 0,
+      active1 = 0,
     };
   }
 
   namespace InstanceIds {
     enum {
-      M_active1,
       M_active2,
       M_active3,
       M_passive1,
       M_passive2,
+      active1,
     };
   }
 
   namespace Priorities {
     enum {
-      M_active1 = 1,
+      active1 = 1,
     };
   }
 
   namespace QueueSizes {
     enum {
-      M_active1 = 10,
       M_active2 = 10,
       M_active3 = 10,
+      active1 = 10,
     };
   }
 
   namespace StackSizes {
     enum {
-      M_active1 = 1024,
+      active1 = 1024,
     };
   }
 
   namespace TaskIds {
     enum {
-      M_active1,
       M_active2,
       M_active3,
+      active1,
     };
   }
 

diff --git a/compiler/tools/fpp-to-cpp/test/top/basic.fpp b/compiler/tools/fpp-to-cpp/test/top/basic.fpp
@@ -14,9 +14,14 @@ module M {
 
   }
 
-  instance active1: Active base id 0x100 \
-    at "Active.hpp" \
-    queue size 10 stack size 1024 priority 1 cpu 0
+}
+
+instance active1: M.Active base id 0x100 \
+  at "Active.hpp" \
+  queue size 10 stack size 1024 priority 1 cpu 0
+
+module M {
+
   instance active2: Active base id 0x200 \
     queue size 10 \
   {