DCAT-2: Fix the usage score order #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 22 22
Lines 487 488 +1
Branches 153 151 -2
=======================================
+ Hits 486 487 +1
Misses 1 1 ☔ View full report in Codecov by Sentry. |
DCAT-2: Trying to ensure test passing DCAT-2: Test removing the waitFor DCAT-2: Use env var for more consistency DCAT-2: Increase timeout that available to the waitFor DCAT-2: Fix the usage score order
eudoroolivares2016
force-pushed
the
DCAT-2
branch
from
62dce94 to
a9081fa
Compare
| @@ -416,8 +416,8 @@ describe('DataCatalog', () => { | |||
|
|
|||
| // Click the Next button | |||
| await waitFor(async () => { | |||
| await user.click(screen.getByRole('button', { name: 'Next' })) | |||
| }) | |||
| await user.click(await screen.findByRole('button', { name: 'Next' })) | |||
There was a problem hiding this comment.
Was getting timeout issues with this intermittently only on GA though
eudoroolivares2016
requested review from
macrouch,
abbottry,
trevorlang,
rushgeo,
dpesall,
daniel-zamora and
dmistry1
dpesall
approved these changes
Jan 28, 2025
macrouch
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature?
Users expect that the usage sort method return the
mostutilized collection first. This is how results are sort on Earthdata Search. We should ensure there are alignedWhat is the Solution?
Updated usage sort parameter to sort by most utilized first per
What areas of the application does this impact?
Sorting on the main data catalog page
Testing
Reproduction steps
lp daacquery parameter to search for lpdaac collectionsUsagethat our results match those we'd expect from CMR/Earthdata searchAttachments
Checklist