-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DCAT-6: Default to cmr landing pages when we cannot find a landing pa… #4
Conversation
…ge associated with the collection
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 22 22
Lines 486 487 +1
Branches 152 151 -1
=======================================
+ Hits 485 486 +1
Misses 1 1 ☔ View full report in Codecov by Sentry. |
@@ -63,6 +63,6 @@ | |||
"typescript": "~5.6.2", | |||
"typescript-eslint": "^8.15.0", | |||
"vite": "^6.0.1", | |||
"vitest": "^2.1.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I bumped these to see if it would just fix the intermittently failing tests the release note's (https://github.com/vitest-dev/vitest/releases/tag/v3.0.0) breaking changes didn't seem applicable to us but, this didn't make much of a difference I figure we should keep up to date but, if people want I can just bump them back down
…ge associated with the collection
Overview
What is the feature?
Data Catalog should default to using cmr landing pages in cases where there is no provided link in the DOI landing page or a
DATA SET LANDING PAGE
landing page in the collectionWhat is the Solution?
Update the logic to fallback to the cmr landing pages in the event above
Some updates to try to reduce the flakiness of some tests and standardize patterns
What areas of the application does this impact?
The Collection results link
Testing
Reproduction steps
http://localhost:5173/?keyword=C1996881752-POCLOUD
this collection returns a 404 in prod see (https://www.earthdata.nasa.gov/data/catalog?keyword=C1996881752-POCLOUD)DOI
or a related url for a data-set landing page continue to workAttachments
Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.
Checklist