Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCAT-6: Default to cmr landing pages when we cannot find a landing pa… #4

Merged
merged 10 commits into from
Jan 22, 2025

Conversation

eudoroolivares2016
Copy link
Contributor

@eudoroolivares2016 eudoroolivares2016 commented Jan 17, 2025

…ge associated with the collection

Overview

What is the feature?

Data Catalog should default to using cmr landing pages in cases where there is no provided link in the DOI landing page or a DATA SET LANDING PAGE landing page in the collection

What is the Solution?

Update the logic to fallback to the cmr landing pages in the event above

Some updates to try to reduce the flakiness of some tests and standardize patterns

What areas of the application does this impact?

The Collection results link

Testing

Reproduction steps

  • **Environment for testing:Prod
  • **Collection to test with:C1996881752-POCLOUD
  1. Navigate to http://localhost:5173/?keyword=C1996881752-POCLOUD this collection returns a 404 in prod see (https://www.earthdata.nasa.gov/data/catalog?keyword=C1996881752-POCLOUD)
  2. Ensure that instead of a 404 it returns you to the cmr landing page (https://cmr.earthdata.nasa.gov/search/concepts/C1996881752-POCLOUD)
  3. Ensure that landing pages that have a DOI or a related url for a data-set landing page continue to work

Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.79%. Comparing base (48688d8) to head (acc90c3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files          22       22           
  Lines         486      487    +1     
  Branches      152      151    -1     
=======================================
+ Hits          485      486    +1     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eudoroolivares2016 eudoroolivares2016 marked this pull request as ready for review January 18, 2025 20:17
@@ -63,6 +63,6 @@
"typescript": "~5.6.2",
"typescript-eslint": "^8.15.0",
"vite": "^6.0.1",
"vitest": "^2.1.8"
Copy link
Contributor Author

@eudoroolivares2016 eudoroolivares2016 Jan 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bumped these to see if it would just fix the intermittently failing tests the release note's (https://github.com/vitest-dev/vitest/releases/tag/v3.0.0) breaking changes didn't seem applicable to us but, this didn't make much of a difference I figure we should keep up to date but, if people want I can just bump them back down

@eudoroolivares2016 eudoroolivares2016 merged commit 1920e11 into main Jan 22, 2025
6 checks passed
@eudoroolivares2016 eudoroolivares2016 deleted the DCAT-6 branch January 22, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants