Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-4344: Refresh order status page faster while order is still creating #1857

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

macrouch
Copy link
Contributor

Overview

What is the feature?

Refresh order status page faster while order is still creating

What is the Solution?

While the order is in the creating state, fetch the order status every 5s (configurable).
Refactor the OrderStatusItem component to be a functional component with Testing Library tests
Adds the last updated day/time to the order status page. This is the last time our backend checked the status of the order (every 60s)

What areas of the application does this impact?

Order status page

Testing

Locally run EDSC with npm run start:optionals
Submit an order, watch the network tab to see how often the retrieval_collections/{id} endpoint is called. While the order is creating it will be every 5s. After it moves to In Progress it will refresh every 60s

This Harmony job works well

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 95.80645% with 13 lines in your changes missing coverage. Please review.

Project coverage is 93.40%. Comparing base (e4598d2) to head (e503675).

Files with missing lines Patch % Lines
.../src/js/components/OrderStatus/OrderStatusItem.jsx 91.66% 6 Missing and 4 partials ⚠️
.../components/OrderStatus/getOrderInfoAndProgress.js 98.08% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1857      +/-   ##
==========================================
+ Coverage   93.34%   93.40%   +0.06%     
==========================================
  Files         777      780       +3     
  Lines       19115    19124       +9     
  Branches     4946     4955       +9     
==========================================
+ Hits        17842    17863      +21     
- Misses       1188     1206      +18     
+ Partials       85       55      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant