Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-4346: Make the entire map to be visible when I select data #1855

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

dpesall
Copy link
Member

@dpesall dpesall commented Feb 7, 2025

Overview

What is the feature?

  • Current behavior allows granules to be partially obscured by the side panel since it overlaps the map.

What is the Solution?

  • Updating the map behavior to be rendered to the right of the panel rather than underneath.

What areas of the application does this impact?

  • EDSC Map
  • Side Panels

Testing

Reproduction steps

  1. On the EDSC home page, select a granule in a collection.
  2. Verify that the entire granule swath is visible.
  3. Drag the side bar back and forth and ensure the map width updates correctly.
  4. Collapse/expand the side panel and ensure the map width updates correctly.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.17%. Comparing base (d84630c) to head (b56d286).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1855      +/-   ##
==========================================
- Coverage   93.33%   85.17%   -8.17%     
==========================================
  Files         777      778       +1     
  Lines       19114    19157      +43     
  Branches     4954     4951       -3     
==========================================
- Hits        17841    16317    -1524     
- Misses       1188     2568    +1380     
- Partials       85      272     +187     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpesall dpesall marked this pull request as draft February 7, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant