-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDSC-4329: Updates bootstrap, sass, node #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## EDSC-4351 #1851 +/- ##
============================================
Coverage ? 93.33%
============================================
Files ? 777
Lines ? 19114
Branches ? 4958
============================================
Hits ? 17841
Misses ? 1188
Partials ? 85 ☔ View full report in Codecov by Sentry. |
daniel-zamora
approved these changes
Feb 4, 2025
dpesall
approved these changes
Feb 4, 2025
trevorlang
approved these changes
Feb 6, 2025
macrouch
added a commit
that referenced
this pull request
Feb 6, 2025
* EDSC-4329: Updates bootstrap, sass, node * EDSC-4329: Fixes tests * EDSC-4329: Fixes lazy loading collection details * EDSC-4329: Fixes tests, removes unused packages * EDSC-4329: Updates Playwright, fixes tests * EDSC-4329: Fixes tests * EDSC-29: Added in tests-passed CI step * EDSC-4329: PR comments * EDSC-4329: Fixes CI workflow * EDSC-4329: Removes unused file * EDSC-4329: Fixes indentation * EDSC-4329: Fixes small icon in spatial selection dropdown * EDSC-4329: Fixes icon padding, dropdown toggle variants * EDSC-4329: Removes unused packages * EDSC-4329: Fixes rebase * EDSC-4329: Fixes icon alignment * EDSC-4329: Fixes playwright tests
macrouch
added a commit
that referenced
this pull request
Feb 6, 2025
* EDSC-4329: Updates bootstrap, sass, node * EDSC-4329: Fixes tests * EDSC-4329: Fixes lazy loading collection details * EDSC-4329: Fixes tests, removes unused packages * EDSC-4329: Updates Playwright, fixes tests * EDSC-4329: Fixes tests * EDSC-29: Added in tests-passed CI step * EDSC-4329: PR comments * EDSC-4329: Fixes CI workflow * EDSC-4329: Removes unused file * EDSC-4329: Fixes indentation * EDSC-4329: Fixes small icon in spatial selection dropdown * EDSC-4329: Fixes icon padding, dropdown toggle variants * EDSC-4329: Removes unused packages * EDSC-4329: Fixes rebase * EDSC-4329: Fixes icon alignment * EDSC-4329: Fixes playwright tests
macrouch
added a commit
that referenced
this pull request
Feb 6, 2025
* EDSC-4329: Updates bootstrap, sass, node * EDSC-4329: Fixes tests * EDSC-4329: Fixes lazy loading collection details * EDSC-4329: Fixes tests, removes unused packages * EDSC-4329: Updates Playwright, fixes tests * EDSC-4329: Fixes tests * EDSC-29: Added in tests-passed CI step * EDSC-4329: PR comments * EDSC-4329: Fixes CI workflow * EDSC-4329: Removes unused file * EDSC-4329: Fixes indentation * EDSC-4329: Fixes small icon in spatial selection dropdown * EDSC-4329: Fixes icon padding, dropdown toggle variants * EDSC-4329: Removes unused packages * EDSC-4329: Fixes rebase * EDSC-4329: Fixes icon alignment * EDSC-4329: Fixes playwright tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature?
Updates bootstrap to v5
Updates from node-sass to sass
Updates to node 22
What areas of the application does this impact?
... everything?
Testing
Compare with production for visual differences. General regression testing
Checklist