Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-4329: Updates bootstrap, sass, node #1851

Merged
merged 17 commits into from
Feb 6, 2025
Merged

EDSC-4329: Updates bootstrap, sass, node #1851

merged 17 commits into from
Feb 6, 2025

Conversation

macrouch
Copy link
Contributor

Overview

What is the feature?

Updates bootstrap to v5
Updates from node-sass to sass
Updates to node 22

What areas of the application does this impact?

... everything?

Testing

Compare with production for visual differences. General regression testing

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (EDSC-4351@e847ca2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...nents/CollectionResults/CollectionResultsTable.jsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             EDSC-4351    #1851   +/-   ##
============================================
  Coverage             ?   93.33%           
============================================
  Files                ?      777           
  Lines                ?    19114           
  Branches             ?     4958           
============================================
  Hits                 ?    17841           
  Misses               ?     1188           
  Partials             ?       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@macrouch macrouch merged commit b54d13e into EDSC-4351 Feb 6, 2025
12 checks passed
@macrouch macrouch deleted the EDSC-4329 branch February 6, 2025 14:32
macrouch added a commit that referenced this pull request Feb 6, 2025
* EDSC-4329: Updates bootstrap, sass, node

* EDSC-4329: Fixes tests

* EDSC-4329: Fixes lazy loading collection details

* EDSC-4329: Fixes tests, removes unused packages

* EDSC-4329: Updates Playwright, fixes tests

* EDSC-4329: Fixes tests

* EDSC-29: Added in tests-passed CI step

* EDSC-4329: PR comments

* EDSC-4329: Fixes CI workflow

* EDSC-4329: Removes unused file

* EDSC-4329: Fixes indentation

* EDSC-4329: Fixes small icon in spatial selection dropdown

* EDSC-4329: Fixes icon padding, dropdown toggle variants

* EDSC-4329: Removes unused packages

* EDSC-4329: Fixes rebase

* EDSC-4329: Fixes icon alignment

* EDSC-4329: Fixes playwright tests
macrouch added a commit that referenced this pull request Feb 6, 2025
* EDSC-4329: Updates bootstrap, sass, node

* EDSC-4329: Fixes tests

* EDSC-4329: Fixes lazy loading collection details

* EDSC-4329: Fixes tests, removes unused packages

* EDSC-4329: Updates Playwright, fixes tests

* EDSC-4329: Fixes tests

* EDSC-29: Added in tests-passed CI step

* EDSC-4329: PR comments

* EDSC-4329: Fixes CI workflow

* EDSC-4329: Removes unused file

* EDSC-4329: Fixes indentation

* EDSC-4329: Fixes small icon in spatial selection dropdown

* EDSC-4329: Fixes icon padding, dropdown toggle variants

* EDSC-4329: Removes unused packages

* EDSC-4329: Fixes rebase

* EDSC-4329: Fixes icon alignment

* EDSC-4329: Fixes playwright tests
macrouch added a commit that referenced this pull request Feb 6, 2025
* EDSC-4329: Updates bootstrap, sass, node

* EDSC-4329: Fixes tests

* EDSC-4329: Fixes lazy loading collection details

* EDSC-4329: Fixes tests, removes unused packages

* EDSC-4329: Updates Playwright, fixes tests

* EDSC-4329: Fixes tests

* EDSC-29: Added in tests-passed CI step

* EDSC-4329: PR comments

* EDSC-4329: Fixes CI workflow

* EDSC-4329: Removes unused file

* EDSC-4329: Fixes indentation

* EDSC-4329: Fixes small icon in spatial selection dropdown

* EDSC-4329: Fixes icon padding, dropdown toggle variants

* EDSC-4329: Removes unused packages

* EDSC-4329: Fixes rebase

* EDSC-4329: Fixes icon alignment

* EDSC-4329: Fixes playwright tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants