Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-4153: Remove the cypress dependencies #1781

Merged
merged 1 commit into from
Aug 12, 2024
Merged

EDSC-4153: Remove the cypress dependencies #1781

merged 1 commit into from
Aug 12, 2024

Conversation

daniel-zamora
Copy link
Contributor

Overview

What is the feature?

Removes cypress from earthdata-search

What is the Solution?

Removed cypress related directories, files, and configs

What areas of the application does this impact?

Cypress will no longer be a testing step.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Sorry, something went wrong.

@daniel-zamora daniel-zamora changed the title EDSC-4153 removes cypress EDSC-4153: Remove the cypress dependencies Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.24%. Comparing base (a572a03) to head (4e63a98).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1781      +/-   ##
==========================================
- Coverage   83.45%   83.24%   -0.21%     
==========================================
  Files         700      700              
  Lines       17504    17503       -1     
  Branches     4597     4569      -28     
==========================================
- Hits        14608    14571      -37     
- Misses       2750     2885     +135     
+ Partials      146       47      -99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daniel-zamora daniel-zamora force-pushed the EDSC-4153 branch 2 times, most recently from f77b017 to 477df5b Compare August 9, 2024 13:09
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait what happened here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

permission change, and the package.json was using the incorrect prep script

@daniel-zamora daniel-zamora merged commit cf0ba87 into main Aug 12, 2024
11 checks passed
@daniel-zamora daniel-zamora deleted the EDSC-4153 branch August 12, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants