-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDSC-3607, EDSC-3950: Refactored SpatialDisplay and updated tests to be RTL. #1711
Conversation
…s if the coordinates don't match.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1711 +/- ##
==========================================
- Coverage 91.96% 91.94% -0.02%
==========================================
Files 725 725
Lines 19395 19361 -34
Branches 4575 4574 -1
==========================================
- Hits 17837 17802 -35
- Misses 1422 1423 +1
Partials 136 136 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Difficult to review because of the functions moving up in the component, but it looks good from my perspective. Maybe the tests could use some tweaking?
…into EDSC-3607
Overview
What is the feature?
Refactored SpatialDisplay to be a functional component and updated tests to use RTL.
What is the Solution?
See what the feature is.
What areas of the application does this impact?
List impacted areas.
Testing
Reproduction steps
Attachments
Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.
Checklist