Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-3607, EDSC-3950: Refactored SpatialDisplay and updated tests to be RTL. #1711

Merged
merged 24 commits into from
Feb 9, 2024

Conversation

bnp26
Copy link
Collaborator

@bnp26 bnp26 commented Jan 29, 2024

Overview

What is the feature?

Refactored SpatialDisplay to be a functional component and updated tests to use RTL.

What is the Solution?

See what the feature is.

What areas of the application does this impact?

List impacted areas.

Testing

Reproduction steps

  • sit
  • N/A
  1. go to http://localhost:8080/search
  2. click on the spatial selection dropdown
  3. go through each spatial option and select an area.
  4. make sure collections load correctly.

Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [N/A] I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (94812fd) 91.96% compared to head (5bcb9ab) 91.94%.

Files Patch % Lines
...src/js/components/SpatialDisplay/SpatialDisplay.js 99.47% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1711      +/-   ##
==========================================
- Coverage   91.96%   91.94%   -0.02%     
==========================================
  Files         725      725              
  Lines       19395    19361      -34     
  Branches     4575     4574       -1     
==========================================
- Hits        17837    17802      -35     
- Misses       1422     1423       +1     
  Partials      136      136              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator Author

@bnp26 bnp26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Difficult to review because of the functions moving up in the component, but it looks good from my perspective. Maybe the tests could use some tweaking?

@dpesall dpesall merged commit 66028e1 into nasa:main Feb 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants