Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-3971: Update feature toggles to be string for bamboo vars #1710

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

eudoroolivares2016
Copy link
Contributor

@eudoroolivares2016 eudoroolivares2016 commented Jan 27, 2024

Overview

What is the feature?

The existing feature toggle needs to be a string otherwise it is getting parsed as truthy. We must update the feature toggles to be strings

What is the Solution?

Update those feature toggles to be string values instead of booleans so that the value that bamboo passes can get parsed with the correct logic

What areas of the application does this impact?

ordering for the order feature toggle and all database interactions as this disabled the secondary toolbar

Testing

Set the toggles for the database toggle and set the toggle for cmr-ordering and the database related rendered components in your override.static.config.json file

Ensure your database is either deleted or otherwise turned off I did so using: pg_ctl -D /usr/local/var/postgresql@14 stop

To test colormaps toggle against prod locally use: C1996881146-POCLOUD

To test cmr-ordering toggle against prod locally use: C1299783631-LPDAAC_ECS

Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Bamboo vars are passed in as strings so we need to key off of a string value instead since otherwise all the vars for this will truthy
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (01d2b53) 91.96% compared to head (7368a34) 91.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1710   +/-   ##
=======================================
  Coverage   91.96%   91.96%           
=======================================
  Files         725      725           
  Lines       19394    19395    +1     
  Branches     4574     4574           
=======================================
+ Hits        17836    17837    +1     
  Misses       1422     1422           
  Partials      136      136           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eudoroolivares2016 eudoroolivares2016 merged commit 81568d7 into main Jan 29, 2024
11 checks passed
@eudoroolivares2016 eudoroolivares2016 deleted the EDSC-3971-2 branch January 29, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants