CUMULUS-4883: Add script to build Iceberg API docker image and push it to ECR as part of the build process.#4464
Conversation
…t to ECR as part of the build process.
ygliuvt
force-pushed
the
cumulus-4883
branch
2 times, most recently
from
1d948ba to
b0c6f57
Compare
|
|
||
| set_iceberg_image_version | ||
|
|
||
| DEPLOY_ICEBERG_API="${DEPLOY_ICEBERG_API:-false}" |
There was a problem hiding this comment.
You mentioned there's another variable - RUN_ICEBERG_INT_TEST - shouldn't we just have a single variable that if it's set will deploy the iceberg API and run the integration tests? Otherwise won't the default of RUN_ICEBERG_INT_TEST=true and DEPLOY_ICEBERG_API=false cause the build to fail because the API won't be running?
There was a problem hiding this comment.
The integration test does not depend on the integration stack (I know it sounds bad) due to access issues from build agent to Sandbox environment. The integration test is run on a locally running server on the build agent so there is no connection between the two, thus two configurations.
There was a problem hiding this comment.
"due to access issues from build agent to Sandbox environment." - would love to talk through why that is.
There was a problem hiding this comment.
In Bamboo. https://ci.earthdata.nasa.gov/build/admin/edit/editBuildTasks.action?buildKey=CUM-CBA-DDIS
I made it a conditional step before running the dev integration stack deployment
4 participants
Summary: Summary of changes
Addresses CUMULUS-4883: Add script to build Iceberg API docker image and push it to ECR as part of the build process
Changes
Build Iceberg API Docker Imagebuild step inDeploy Dev Integration Stackbuild stage. The new build step will build the Iceberg API image with the PR branch and push the image to the Sandbox ECR and update the ECS Iceberg API task to run with the newly built image.See https://ci.earthdata.nasa.gov/browse/CUM-CBA4796 for the CI build.
You can use AWS console to verify the Iceberg API image that is built by the CICD is indeed pushed to ECR and deployed to ECS.
Verify that Iceberg api queries return the expected results.
PR Checklist
📝 Note:
For most pull requests, please Squash and merge to maintain a clean and readable commit history.