CMR-10282: Migrating from serverless framework to CDK #388
+27,842
−15,866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #388 +/- ##
==========================================
+ Coverage 88.42% 88.57% +0.15%
==========================================
Files 24 24
Lines 1218 1217 -1
Branches 269 258 -11
==========================================
+ Hits 1077 1078 +1
+ Misses 141 139 -2 ☔ View full report in Codecov by Sentry. |
| docker build -t $dockerTag . | ||
|
|
||
| # Convenience function to invoke `docker run` with appropriate env vars instead of baking them into image | ||
| dockerRun() { |
There was a problem hiding this comment.
Currently deployments are done via bamboo-specs on CMR stac will need to update that repo to put these new variables or otherwise remove cmr-stac from the bamboo specs deployment
There was a problem hiding this comment.
Updated bamboo specs so different env deployments are decoupled that way as this makes it through envs we can just push an update to the bamboo build plan
eudoroolivares2016
requested review from
dpesall,
william-valencia,
macrouch and
daniel-zamora
and removed request for
dpesall
|
Needing to fix a content-encoding issue where passing the |
macrouch
reviewed
Feb 4, 2025
| "watch": "onchange 'src/**' -- npm run run-synth-dev", | ||
| "start:api": "sam local start-api -t ./cdk/cmr-stac/cdk.out/cmr-stac-dev.template.json --warm-containers LAZY --port 3000 --docker-network host", | ||
| "prestart": "npm run run-synth-dev ", | ||
| "start": "node start.js", |
There was a problem hiding this comment.
This command doesn't work for me.
➜ npm start
> [email protected] prestart
> npm run run-synth-dev
> [email protected] run-synth-dev
> cd cdk/cmr-stac-dev && npm run cdk synth -- --quiet
> [email protected] cdk
> cdk synth --quiet
sh: cdk: command not found
The preinstall script runs on cdk/cmr-stac, not cdk/cmr-stac-dev
There was a problem hiding this comment.
This should be fixed now
macrouch
reviewed
Feb 4, 2025
macrouch
reviewed
Feb 4, 2025
macrouch
reviewed
Feb 4, 2025
eudoroolivares2016
force-pushed
the
CMR-10282
branch
from
87b2887 to
05f62e2
Compare
macrouch
reviewed
Feb 5, 2025
CMR-10282: Fix install up gh actions CMR-10282: Fix tests and prettier CMR-10282: Fix prettier CMR-10282: Move ajv-formats to dev deps; use linter consistently CMR-10282: Fix encoding issue from compression; more consistent env variables CMR-10282: Update dep remove comment CMR-10282: PR comments CMR-10282: Make these const values since they don't need to be updated for dev stack CMR-10282: Flip back the suffix CMR-10282: Remove log suffix from docs bucket CMR-10282: Removing names CMR-10282: Add bucket policy to s3 CMR-10282: Fix spacing; run prettier CMR-10282: Migrating from serverless framework to CDK CMR-10282: stac is at least running CMR-10282: Local env and compiled prod cdk working CMR-10282: Working deployment CMR-10282: Obfuscate destination arn, add bucket deployment for the documentation upload CMR-10282: Remove serverless its deploying on top of the serverless deployment successfully EDSC-10282: Update the names of the path to try to get it working in SIT CMR-10282: Cleaning up CMR-10282: Working cleaning up more serverless things CMR-10282: Fixing non-null linter warnings by ignoring cdk files CMR-10282: Fix the tsconfig issues and get tests running CMR-10282: More cleanup CMR-10282: Remove unused env var remove expresswrapper.js CMR-10282: Cleaning up more CMR-10282: use cdk lib CMR-10282: Remove debugging lines CMR-10282: Simplify dev stack
eudoroolivares2016
force-pushed
the
CMR-10282
branch
from
311a136 to
f8e9053
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature?
Migrate away from
serverlessframework to instead usingaws-cdkthis also bumps node to node 22What is the Solution?
Replaces
serverlesswithaws-cdkWhat areas of the application does this impact?
Infrastructure of the application
Testing
Reproduction steps
Attachments
Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.
Checklist