Fix #181, correct off-by-one error in CI_LAB_ReadUpLink

[thnkslprpt]

Checklist

• I reviewed the Contributing Guide.
• I signed and emailed the appropriate Contributor License Agreement to [email protected] and copied [email protected].

Describe the contribution

• Fixes off-by-one error in CI_LAB_ReadUpLink() #181
  • Updates the for loop condition in CI_LAB_ReadUpLink() to run as many times as expected.

Couple minor fixes piggy-backing on this PR:

• remove duplicate call to CFE_MSG_GetMsgId() in CI_LAB_TaskPipe() - probably a copy-paste leftover from a previous refactor
• remove unused declarations CI_LAB_Noop() and CI_LAB_ResetCounters() - also leftovers from a previous refactor

Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).

System(s) tested on
Debian 12 using the current main branch of cFS bundle.

Contributor Info
Avi Weiss   @thnkslprpt