Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

150 conditional error code review #400

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Conversation

Donnie-Ice
Copy link
Contributor

No description provided.

@Donnie-Ice Donnie-Ice self-assigned this Feb 4, 2025
@Donnie-Ice Donnie-Ice linked an issue Feb 4, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 75.96%. Comparing base (14ee573) to head (0111688).
Report is 27 commits behind head on dev.

Files with missing lines Patch % Lines
src/core/crypto_aos.c 0.00% 0 Missing and 2 partials ⚠️
src/core/crypto_tc.c 0.00% 0 Missing and 2 partials ⚠️
src/core/crypto_tm.c 0.00% 0 Missing and 2 partials ⚠️
src/core/crypto.c 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #400      +/-   ##
==========================================
- Coverage   75.97%   75.96%   -0.01%     
==========================================
  Files          81       81              
  Lines       22263    22281      +18     
  Branches     1807     1811       +4     
==========================================
+ Hits        16914    16926      +12     
- Misses       4707     4709       +2     
- Partials      642      646       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jlucas9 jlucas9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Donnie-Ice Donnie-Ice merged commit 1acbc5a into dev Feb 5, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conditional Error Code Review
5 participants