-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMR-10254: Subscription Worker additions: Adding AccessControl functionality, tests, code structure change, and fixing Docker. #2211
base: master
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,91 @@ | |||
import sys | |||
import os | |||
sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), '..', '..', 'src'))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your other tests don't do this, why are you adding src directory for just this one file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I was originally creating this test, the test couldn't find the file in the src directory. I now have a shell script called run_tests-cicd.sh where I set the PYTHONPATH environment variable and put in the src directory. That is why I no longer needed it in the other files. Not sure which is the better approach. I have deleted this line out of this file, as it didn't work anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of questions.
Overview
What is the feature/fix?
Subscription Worker additions: Adding AccessControl functionality, tests, code structure change, and fixing Docker.
What is the Solution?
Subscription Worker additions: Adding AccessControl functionality, tests, code structure change, and fixing Docker.
What areas of the application does this impact?
Subscription worker.
Checklist