Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-10254: Subscription Worker additions: Adding AccessControl functionality, tests, code structure change, and fixing Docker. #2211

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

eereiter
Copy link
Contributor

@eereiter eereiter commented Feb 5, 2025

Overview

What is the feature/fix?

Subscription Worker additions: Adding AccessControl functionality, tests, code structure change, and fixing Docker.

What is the Solution?

Subscription Worker additions: Adding AccessControl functionality, tests, code structure change, and fixing Docker.

What areas of the application does this impact?

Subscription worker.

Checklist

  • I have updated/added unit and int tests that prove my fix is effective or that my feature works
  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors corrected
  • I have removed unnecessary/dead code and imports in files I have changed
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have cleaned up integration tests by doing one or more of the following:
    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

@eereiter eereiter changed the title CNR-10254: Subscription Worker additions: Adding AccessControl functionality, tests, code structure change, and fixing Docker. CMR-10254: Subscription Worker additions: Adding AccessControl functionality, tests, code structure change, and fixing Docker. Feb 5, 2025
@@ -0,0 +1,91 @@
import sys
import os
sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), '..', '..', 'src')))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your other tests don't do this, why are you adding src directory for just this one file?

Copy link
Contributor Author

@eereiter eereiter Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I was originally creating this test, the test couldn't find the file in the src directory. I now have a shell script called run_tests-cicd.sh where I set the PYTHONPATH environment variable and put in the src directory. That is why I no longer needed it in the other files. Not sure which is the better approach. I have deleted this line out of this file, as it didn't work anyway.

Copy link
Contributor

@jceaser jceaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants