Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sizeof(pointer) fixes #36

Open
wants to merge 4 commits into
base: current
Choose a base branch
from

Conversation

j-huff
Copy link

@j-huff j-huff commented Aug 28, 2024

Fixes issues related to incorrect use of sizeof.

Not exactly sure of the the intended purpose of the line:

privateKey = (privKeyBuf + (sizeof privKeyBuf - 1)) - privateKeyLen;

There's no way this was correct, as it would run off the beginning of the privKeyBuf (sizeof privKeyBuf would evaluate to 4 or 8 depending on the size of pointers).

@j-huff
Copy link
Author

j-huff commented Aug 29, 2024

@plindner Is this repo accepting public pull requests?

@SkyDeBaun
Copy link
Collaborator

@iondev33 - please take a look at John's suggested commits: I believe they are all valid corrections to incorrect uses of sizeof (i.e. they address the incorrect use of sizeof() on pointers.. rather than the intended memory block the pointers point to).

@iondev33
Copy link
Collaborator

iondev33 commented Jan 7, 2025

@j-huff @SkyDeBaun Yes, we do intend to accept public pull request but because our codebase is managed in a private repo, I will have to "pull" the publicly submitted branch into our private repo first. Test, merge, test, and then release it through the usual mirror process.

I have not done that entire process once yet (it used to be done by Ohio U) but I will. I am adding this to top of my to-do list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants