Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
panstarrs_get_lightcurve using lsdb #344
panstarrs_get_lightcurve using lsdb #344
Changes from 5 commits
f80e71a
73bbc93
0fc8d3a
c31a2d8
0acf2ee
0350d1b
381baad
2d82df4
58f0df7
a92a4c5
75b7337
5a32024
ebb9c75
3638adc
8b45d9b
fedbd7e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are
to_numeric
and 'coerce' required here? Asking because I'm just really surprised and curious.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This represents a day of my life that I will never get back. It turns out that lsdb returns some interesting data types (eg.
double[pyarrow]
), which pandas seamlessly handles, and hides, unless you think to ask about data types. Unfortunately, other codes do not handle them well, namely our plotting functions.... This is the way I found of getting the data types converted into data types in the data frames that can be handled by plotting. Maybe there is another, simpler, way of doing it, but this is functional, and not all combinations of these things are functional, ie., I believe.astype
alone doesn't work. Thecoerce
I believe was an attempt to handlenan
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh interesting. I wonder if it's fundamentally a result of choices made during the catalog import process rather than LSDB itself. I'll try to look at the data types more closely before I import another catalog to try to avoid these hurdles with the ones we put out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This difference between pyarrow/parquet vs pandas/numpy dtypes certainly came up before, and for end users I see all the reasons to provide the outputs in the latter, even if under the hood it keeps mapping to what parquet likes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either case, having this separated out into an issue would be superb, so then we can easily pull in Melissa et al in the discussion.