Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maint] Fix CI #63

Merged
merged 12 commits into from
Feb 20, 2025
Merged

[Maint] Fix CI #63

merged 12 commits into from
Feb 20, 2025

Conversation

psobolewskiPhD
Copy link
Member

@psobolewskiPhD psobolewskiPhD commented Feb 20, 2025

closes: #62
Trying to fix CI.
Y'all can feel free to push!

@psobolewskiPhD
Copy link
Member Author

derped the python 3.10 version, needs quotes. Will let some of the other jobs run before pushing fix

@psobolewskiPhD
Copy link
Member Author

@DragaDoncila
do the warnings mean anything to you

testing/test_details.py::test_plugin_getattr_raises_errors
    /private/tmp/.tox/py313-macos/lib/python3.13/site-packages/napari_plugin_engine/manager.py:408: UserWarning: Module '4403625472' from plugin 'donttouch' has no hooks! Consider disabling or uninstalling this plugin. If you are a developer, please check your entry point.

@DragaDoncila
Copy link
Contributor

lol @psobolewskiPhD yes kinda. Basically, this test makes sure that if a plugin's class raises errors when you try to access an attribute on the class, it can still get registered. I have no idea why that test is there at all.

Sometime later, we noticed plugins were declaring the plugin entrypoint, but not actually adding any hook implementations, and decided to warn the user on that. Looks like when we did this, we didn't update that test to include a hook in the module.

So I'd say we need to ignore that warning explicitly for that test maybe. I think you can do that with a pytest mark, something like @pytest.mark.filterwarnings("ignore::UserWarning:Module"). Since the module number is probably auto-generated I'm not sure if you can write any more of the warning message.

@psobolewskiPhD
Copy link
Member Author

@DragaDoncila it looks like it's (at least) 15 tests with that warning?
https://github.com/napari/napari-plugin-engine/actions/runs/13426463152/job/37510226637?pr=63#step:5:153
Maybe we just filter it at pyproject.toml?
https://github.com/napari/napari/blob/c3fdd6c711336c22253751ebf42ae4410badf626/pyproject.toml#L382

Anyhow, everything else seems good to go.

@DragaDoncila
Copy link
Contributor

Maybe we just filter it at pyproject.toml?

Yep, fine by me!

@psobolewskiPhD
Copy link
Member Author

Copy link
Contributor

@DragaDoncila DragaDoncila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glorious @psobolewskiPhD 🤩! Thanks for wading through all that.

@DragaDoncila DragaDoncila merged commit b6f1979 into main Feb 20, 2025
14 checks passed
@DragaDoncila DragaDoncila deleted the fix_CI branch February 20, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI is totally broken and needs attention
2 participants