-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maint] Fix CI #63
[Maint] Fix CI #63
Conversation
derped the python 3.10 version, needs quotes. Will let some of the other jobs run before pushing fix |
@DragaDoncila
|
lol @psobolewskiPhD yes kinda. Basically, this test makes sure that if a plugin's class raises errors when you try to access an attribute on the class, it can still get registered. I have no idea why that test is there at all. Sometime later, we noticed plugins were declaring the plugin entrypoint, but not actually adding any hook implementations, and decided to warn the user on that. Looks like when we did this, we didn't update that test to include a hook in the module. So I'd say we need to ignore that warning explicitly for that test maybe. I think you can do that with a pytest mark, something like |
@DragaDoncila it looks like it's (at least) 15 tests with that warning? Anyhow, everything else seems good to go. |
Yep, fine by me! |
Ok, i think the filter is working now: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glorious @psobolewskiPhD 🤩! Thanks for wading through all that.
closes: #62
Trying to fix CI.
Y'all can feel free to push!