Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update viewer.md to include spacing for grid mode #573

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

psobolewskiPhD
Copy link
Member

References and relevant issues

Depends on napari/napari#7597
Part of #568

Description

Updates the copy in the viewer tutorial to mention the new spacing parameter.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 15, 2025
@psobolewskiPhD
Copy link
Member Author

psobolewskiPhD commented Feb 15, 2025

I think this is the bare minimum? We could include a screenshot of the menu.
cc: @TimMonko

@TimMonko
Copy link
Contributor

TimMonko commented Feb 16, 2025

Thanks for getting this started. I tried to add an image and more detail. I added more detail than in some of the other sections to the tutorial since this is the only place in the docs where grid is discussed and its not really a 'standard' in image visualization, unlike something like transpose.

To do this, I submitted a PR to your branch (psobolewskiPhD#73). From what I'm reading, this means that you should be able to merge it and then it would get added to this PR?

Let me know what happens 😅

add widget image and more detail
Copy link
Member

@jni jni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@melissawm
Copy link
Member

I updated this branch because I am seeing some NumPy 1.x/2.x errors in the rendered output. Let's see if this helps

@jni jni merged commit 2042251 into napari:main Feb 18, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants