Support NTP server details in base, EOS #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In support of adding details to NTP server dictionaries, support detection of non-total TypedDicts and change the logic to only error if there are EXTRA keys instead of missing keys.
Support returning details regarding individual NTP servers based on openconfig models (/system/ntp/servers/server)
bewing
commented
Jan 22, 2025
ktbyers
reviewed
Jan 22, 2025
Since we only have a limited set of models that we are testing subsets of keys for, we should explicitly only allow subsets when testing those getters.
Making NTPPeerDict and NTPServerDict non-identical caused issues with typing since we wre unable to assert the type of the return dictionary easily. This refactor allows us to explicitly state the return type for each function.
ktbyers
approved these changes
Feb 10, 2025
| "prefer": bool, | ||
| "network_instance": str, | ||
| "source_address": str, | ||
| "key_id": int, |
There was a problem hiding this comment.
So these are all optional key-values which may be returned?
There was a problem hiding this comment.
That is correct. If we get to the point where all drivers return it in all situations, we could make it non-optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on models from openconfig-system, return optional additional data regarding NTP servers for the first supported driver (EOS).