Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pint.fitter #1884

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Conversation

abhisrkckl
Copy link
Contributor

@abhisrkckl abhisrkckl commented Feb 10, 2025

Reduce code duplication in pint.fitter, e.g., between WLSFitter and DownhillWLSFitter.

A side benefit of this is that it simplifies the Fitter classes, making it easier to implement #1660.

I accidentally merged #1883 into this, so that should be merged first.

@abhisrkckl abhisrkckl changed the title Refactor Fitters WIP: Refactor Fitters Feb 10, 2025
@abhisrkckl abhisrkckl changed the title WIP: Refactor Fitters Refactor pint.fitter Feb 11, 2025
@abhisrkckl abhisrkckl added the awaiting review This PR needs someone to review it so it can be merged label Feb 11, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 96.52174% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.79%. Comparing base (23870cf) to head (b38db89).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/pint/fitter.py 97.97% 2 Missing ⚠️
src/pint/models/timing_model.py 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1884      +/-   ##
==========================================
- Coverage   69.84%   69.79%   -0.06%     
==========================================
  Files         110      110              
  Lines       25740    25674      -66     
  Branches     4072     4056      -16     
==========================================
- Hits        17977    17918      -59     
+ Misses       6627     6622       -5     
+ Partials     1136     1134       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review This PR needs someone to review it so it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant