Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore asan warnings (clang) #3844

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

ctummon
Copy link
Contributor

@ctummon ctummon commented Jun 20, 2022

Wanted to test out my WSL dev environment with Visual Code so took a crack at some of the address sanitizer warnings

1.) Added function attribute to ignore false unsigned int overflow warnings which fixes:
#3658
#3659

2.) Added blacklist file for Clang Address Sanitizer.

Also when running Address Sanitizer with core_test aborts in a couple of places:

config_a.network_params.network.is_dev_network () 
nano::confirmation_solicitor::{ctor}
nano::active_transactions::request_confirm()
config.network_params.network.is_dev_network ()
void nano::node::ongoing_backlog_population ()

It doesn't like that network_params is a reference and it is being accessed on different threads.

Is this a known issue or should I create a new issue?

@@ -1 +0,0 @@
src:*ed25519*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this file was used, correct me if I'm wrong

@@ -247,11 +247,25 @@ else()
endif()

if(${USING_ASAN} OR ${USING_ASAN_INT})

if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-fsanitize-blacklist and -fsanitize=integer only seem to be available with Clang so I added some checks

@ctummon
Copy link
Contributor Author

ctummon commented Jun 21, 2022

OSX (RocksDB) is failing on core_test: error code '124' after "active_transactions.fork_filter_cleanup" looks like a false positive?

Same error for the code of conduct PR:
https://github.com/nanocurrency/nano-node/runs/6762524136?check_suite_focus=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant